You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 26, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @generationmake 👋 Can you please test with your receiver and let me know if those GNRMC messages are decoded successfully? I'd also love to have a GLRMC as well as a GARMC message so I can feed them into the unit test system. Can you provide those datasets?
Hi @aentinger
decoding of GPS, GLONASS and GNRMC messages works and seems to be correct.
Unfortunately I couldn't get a fix on the GLONASS signal, so I couldn't record a message. I will do more tests on this.
Additionally I haven't yet configured a Galileo receiver. I will figure out how to do this and perform a test.
Good morning @generationmake 👋 I'll be merging this then since the RMC message for Galileo should have the exact same setup, I don't think there's a need right now to test it individually.
HI @aentinger
I managed to get a GLONASS dataset of u-blox NEO-7M: $GLRMC,185101.00,A,4838.00179,N,01301.60481,E,4.246,167.52,091120,,,A*76
I tested and it worked fine.
I also reviewed the code and it is OK to merge.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @generationmake 👋 Can you please test with your receiver and let me know if those
GNRMCmessages are decoded successfully? I'd also love to have aGLRMCas well as aGARMCmessage so I can feed them into the unit test system. Can you provide those datasets?This fixes #19.